Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for markdown column alignment #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for markdown column alignment #181

wants to merge 2 commits into from

Conversation

WillAbides
Copy link

resolves #173

This adds support for column alignment in markdown tables so that the rendered markdown table will have the same column alignment as the text version.

An example from a test:

|   DATE   |       DESCRIPTION        | CV2  | AMOUNT |
|----------|:-------------------------|-----:|:------:|
| 1/1/2014 | Domain name              | 2233 | $10.98 |
| 1/1/2014 | January Hosting          | 2233 | $54.95 |
| 1/4/2014 | February Hosting         | 2233 | $51.00 |
| 1/4/2014 | February Extra Bandwidth | 2233 | $30.00 |

renders as:

DATE DESCRIPTION CV2 AMOUNT
1/1/2014 Domain name 2233 $10.98
1/1/2014 January Hosting 2233 $54.95
1/4/2014 February Hosting 2233 $51.00
1/4/2014 February Extra Bandwidth 2233 $30.00

@olekukonko
Copy link
Owner

@mattn what do you think?

@mfridman
Copy link

This would be extra fantastic. Especially as more and more apps add proper markdown support.

Anything the community can do to help out? cc @mattn (👋 long time)

@jippi
Copy link

jippi commented Apr 28, 2023

Would love to see this land. @olekukonko is the code/approach fine? if yes, I'm happy to do the work to revive this PR so its mergeable :)

@olekukonko
Copy link
Owner

@jippi will review this in detail and revert ... however this may be highly dependent on the introduction of theme

@jippi
Copy link

jippi commented May 2, 2023

@olekukonko thank you, I appreciate it :) Please let me know if I can support it in any way as well

@WillAbides
Copy link
Author

I noticed the activity here and merged master into the PR branch.

@jippi
Copy link

jippi commented May 8, 2023

Thank you @WillAbides ! :)

@olekukonko How does it look from your point of view? Does it need any further polishing / tweaks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown column alignment
4 participants
@WillAbides @olekukonko @mfridman @jippi